>I've added this ticket: > >http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2258-libxml-xml_mini-backend-producing-incorrect-hashes > >Showing a case where the libxml backend produces an incorrect hash >when performing: > > Hash.from_xml > >Would be great to get this fixed before the next release of Rails >specifically because I've also got a benchmark showing using libxml >is 25x faster with a large XML file than than REXML. > >In the ticket is a reference to this repo where I have both the >benchmark and a test implementation I'd like feedback on. > > http://github.com/stepheneb/rails_hash_from_xml/tree/master > >I'm not sure what is the cleanest way to implement one set of tests >for multiple xml_mini backends. > >What I've done works but there's probably a better way.
Here's a new version that adapt's 10 of Aaron's tests for the nokogiri backend and runs them agains all of the alternate xml_mini backends: http://github.com/stepheneb/rails_hash_from_xml/blob/823a8b6b4c2bad04a27e9131082d816e8c19990e/test/test_rexml_equality.rb libxml fail 2, nokogiri and jdom pass all 10. ticket updated: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2258-libxml-xml_mini-backend-producing-incorrect-hashes#ticket-2258-2 will attach a patch against rails directly if feedback is positive --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
