On 16 Apr 2009, at 13:06, Manfred Stienstra wrote: > Sure, but I see new code without tests in the commits.
On a cursory look I don't see anything that intends to change existing behaviour - can you point something out. > I would expect a rewrite to happen in a separate branch and be > merged once > it's done, in which case it would contain tests. I had the impression > that this was what Yehuda was doing, but maybe I'm wrong. Probably the reason for merging back in now before refactoring has been completed is that it becomes harder and harder to merge without conflicts becoming very difficult to resolve - e.g. the work done on improving performance in development mode in the run-up to 2.3 has been ignored for the moment. > Even though I can't imagine doing a large refactor without backing it > up with tests, I wouldn't mind their approach too much if they would > let us know their plans. I obviously can't merge the Rails master > branch with my own work right now because that would introduce too > many test failures. I agree it's all a little bit mysterious at the moment - I'm putting off submitting anything substantial to Lighthouse because I don't want to waste time on something that's being refactored away. It'd be nice to know who is exactly working on what - for example is your work on refactoring AR scopes an 'official' project or just something you've taken upon yourself? It's been mentioned in a few LH tickets which I might have taken a stab at. I'm assuming that there's a core team IRC/ Campfire chat area where these things are being discussed. >> What we could do with is a decent set of specs that cover what's >> going >> to be the public API separate from the current test suite which is >> tightly coupled to the current codebase. We could also do with a test >> application for integration testing. > > That would be great, but that would also be supplemental to unit > tests. Obviously. :-) Andrew White --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
