On Fri, Sep 04, 2009 at 12:52:10PM -0700, Chad Woolley wrote: > > On Fri, Sep 4, 2009 at 11:27 AM, Czarek <[email protected]> wrote: > > Perhaps a timeout within which the build should be fixed? I mean it > > doesn't take hours for CI to detect the problem. And then mail if fix > > doesn't come in time. > > That's a good idea. How about this: > > 1. The first three red builds notify only the core team members (at > the undisclosed location where they congregate) > 2. After three red builds (more than enough chances to fix the test, > revert the change, or comment the test), this list starts getting the > failure emails. > > Three is arbitrary, it could be more...
Yeah, it is funny. Seriously though, in theory the code shouldn't leave the developer's workstation unless it passes all the tests. If this isn't possible (different database drivers needed for testing, etc.) and CI is done on another machine on source already pushed, things get complicated. Especially if the test runner takes a few minutes. All I can get is dumb ideas at this point while trying to think of a workaround. And it doesn't help that I'm not too bright. I honestly give up. Assume someone does a rebase with that broken repos within those few minutes... In this case mailing everyone about the broken build seems to be the best thing that can be done. My reaction to such a mail would probably be: "someone is fixing it right now anyway, so why bother? These guys know what they are doing. They don't commit stuff and go on a holiday without waiting for CI to pass." I apologize if anything I said seemed insulting or disrespectful - I would never be my intention. -- Cezary Bagiński --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
