On Sep 13, 2009, at 11:06 AM, Rodrigo Rosenfeld Rosas wrote:
> Hi, I have some doubts considering contributions to Rails. > > For instance, in attachments follows a patch to change from: > > default.config = config if config > default.config ||= Configuration.new > > To: > > default.config = config || Configuration.new > > That seems more clear to me. > > This little change really doesn't make much difference but I think it > makes the code a bit cleaner... Opening an issue in LightHouse to do > just that seems a little too much in my opinion. Is there any way that > we can do little changes like this in an easy way, such as happens in > docrails project? Maybe some Rails fork for some fast code cleaning > with > open commit access? That change is not equivalent unless default.config.nil? to start with. I'd want to know that such "fast code cleaning" wasn't going to inadvertently break something. Is there even a test that guarantees this change doesn't break something? I think that having to open a ticket is exactly the right hurdle for the general developer population. With a sufficient history, one might be offered commit rights that removes this hurdle, but until then I think that the Rails core team should stand firm on tickets for patches. -Rob > ... > Thanks in advance, > > Rodrigo. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
