Hi Mateo, I think that maybe it would be better to wait for Fuchs to adapt his change to master before I rewrite the patch.
But, anyway, I will still need some help on how to modify the documentation and how to write the tests... I am waiting for Fuchs feedback before I continue... Until there, help with documentation and tests are welcome! :) Thanks, Rodrigo. Mateo Murphy escreveu: > Hi Rodrigo, > > As I was looking at your patch, I realized that some of the changes > made to validations in 2.3.4 haven't been moved over to activemodel > yet, and moving that code over would conflict with the code you're > changing. I've email Sven Fuchs (who worked on those changes) about > this, and I'm waiting to hear back from him on this, but you might > want to wait before continuing working on your patch. In the meantime, > you can check out the validation code in 2.3.4 to see what was changed > and how that would affect your patch. > > Cheers, > > mateo > > On 2-Jan-10, at 5:52 PM, Rodrigo Rosenfeld Rosas wrote: > > >> I've done some experiment writing a patch to support a full_message >> option on Rails validations, as can be seen here: >> >> http://groups.google.com/group/rubyonrails-core/msg/5bf5c89330805373 >> >> I would like to finish the patch, writing the documentation and tests >> and submit it to Lighthouse. >> >> But I don't know how to proceed with documentation, since it is not >> very >> DRY... >> >> Should I send a description to appreciation and then copy and paste it >> on every validation method? >> >> If so, would the following description be ok? >> >> "Configuration options: >> * <tt>message</tt> - A custom error message (default is: "can't be >> blank"). <tt>full_message</tt> can >> be specified instead, in which case the humanized attribute name won't >> be prepended to the message. >> You have to choose between either <tt>message</tt> or >> <tt>full_message</tt>, not both. If that happens, >> <tt>full_message</tt> takes precedence. >> ..." >> >> The only difference between validations would be the default... >> >> >> Regarding test writing, I would also ask for some guidance on it. >> >> I've noted that not all options are tested on each validation >> respective >> test. >> >> So, I would like to know if I should add a test on >> with_validations_test.rb, >> add a new test file or add a new test for every validation class. >> >> Please, how should I proceed? >> >> Thanks in advance, >> >> Rodrigo. >> >> -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-c...@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
