I read the Rails 3 Beta call email and I wanted to try to raise this ticket again to maybe get it a bit more visibility before the beta comes out. Anyone feel like commenting on this patch? I've found it helpful, anyway!
On Tue, Jan 5, 2010 at 2:38 PM, Josh Symonds <[email protected]> wrote: > This isn't *necessarily* a problem. If you have an association named > :except you can still eagerly load it using either the array syntax: > > User.find(:all, :include => [:comments, :except]) > > Or just the regular symbol notation: > > User.find(:all, :include => :except) > > If you include it in the hash notation though, it definitely will think > you're going to specify column names to remove from the select: > > User.find(:all, :include => {:comments => :except}) > > Will now bomb out, where before it would assume that you want to include > comments and then include except on comments, like you said. In making the > patch I figured the amount of people who would be helped by the performance > improvements probably outweighs the number of people who have associations > named "except." But hey, I could be wrong. > > Josh > > On Tue, Jan 5, 2010 at 2:30 PM, Jeremy Evans <[email protected]>wrote: > >> On Tue, Jan 5, 2010 at 12:06 PM, Josh Symonds <[email protected]> >> wrote: >> > I made a patch to allow eager loading to exclude specified columns on >> the >> > eagerly-loaded models. If you have a model that you want to load for a >> > specific reason -- like, say, you have lots of users, and you want to >> grab >> > all their posts but exclude the posts' bodies -- you can now specify >> that by >> > going: >> > >> > User.find(:all, :include => {:posts => {:except => :body}}) >> >> Isn't this already supported syntax (which would load the :except >> association for posts and the :body association for excepts)? Not >> that I think having an association named :except is a good idea, but >> it's something to consider. >> >> Jeremy >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<rubyonrails-core%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> >> >> >> > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
