Hello, I'm really new to contributing to Rails, so I'm not sure how is the process like. I've wrote this patch some time ago, do I need to get people to +1 it to get it applied? Is there anything else expected from me?
Thanks. 2010/6/12 J. Pablo Fernández <[email protected]>: > Hello, > I've noticed that Rails was not properly escaping the name of a table when > dropping an index which caused it to generate invalid SQL when the table was > named "values". I've reported and then made a patch for > it: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4809 > The patch is in the issue and you can also see my change in > here: http://github.com/pupeno/rails/commit/13f9869896f5b39dd3558a2938ffedb2f0eb9e9d > I wrote a test for it but I'm not sure if that's the proper style of > testing; actually, I'm quite sure it isn't, but since I need to create a > separate table for this test I wasn't sure what was the best approach. > Anyone cares to tell me so I can improve this patch? > > Thanks. > -- > J. Pablo Fernández <[email protected]> (http://pupeno.com) > -- J. Pablo Fernández <[email protected]> (http://pupeno.com) -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
