Intuitive :)

Funny you should mention this. I just finished up the parts of the 
SqlserverCompiler that deal with taking the limit/offset (taken/skipped) and 
wrapping up all the clauses for a lean count. Basically passing a few tests the 
adapter was failing in RelationTest. I added these just to make sure I was in 
parity with the MysqlCompiler.

http://github.com/rails-sqlserver/activerecord-sqlserver-adapter/commit/d295b2e18cb1581fc67be57756a82d26642952fd#L2R59

Notice how I use #size because I know from the ActiveRecord docs and tests that 
this issues a count anyway.


On Aug 3, 2010, at 11:19 AM, Mislav Marohnić wrote:

> In my opinion, this should never return a value larger than 5:
> 
>   Model.where(blah blah).order(blah blah).limit(5).count
> 
> Intuitive? Counter-intuitive?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To post to this group, send email to rubyonrails-c...@googlegroups.com.
> To unsubscribe from this group, send email to 
> rubyonrails-core+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/rubyonrails-core?hl=en.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to rubyonrails-c...@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.

Reply via email to