btw, let's get on the topic here. it seems like we should discuss about whether we should include jquery as one of the default options in rails. if you actually look at the commit i did. the commit doesn't actually complicate the code much.
and, one obvious thing that everyone should have noticed recently is that more and more people prefer to use jquery as the default javascript library for rails. and, i think that is one of the reasons why the introduction of "config.action_view.javascript_expansions" in the latest rails 3. so, i really think that this patch should be committed. i really want to see how other core members think about this. siong. On Sat, Sep 11, 2010 at 6:52 PM, Michael Koziarski <[email protected]>wrote: > > i actually +1 for github pull request. they just made it a lot easier to > use > > now. btw, my pull request has already been sent in. feel free to leave > > comments there. :) > > The most important thing for pull requests to get right is to make > community members (e.g. non committers) able to comment / review a > pull request. It seems the latest github release has done a pretty > good job with that. > > -- > Cheers > > Koz > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<rubyonrails-core%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
