On Feb 16, 2011, at 12:10 PM, Robert Pankowecki wrote:
On Wed, Feb 16, 2011 at 5:59 PM, Aaron Patterson
<[email protected]> wrote:
The intentional change fixes this bug:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4598-default_scope-treats-hashes-and-relations-inconsistently-when-overwriting
If there is a different way to fix that ticket, I'm happy to apply
patches.
The different way is to make both cases return an empty array. David
(who created the ticket) expects something different but I am not sure
that this is what most people expect.
Could we provide a different method for such behavior as expected by
David ?
Agreed, the OR behavior seems inconsistent and unintuitive. In fact,
the original solution suggested was to AND them together to make case
1 consistent with case 2 (rather than ORing them to make case 2
consistent with case 1).
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4598-default_scope-treats-hashes-and-relations-inconsistently-when-overwriting
#ticket-4598-2
That seems more sane and less radical than having a single special
case where chained methods get ORd. Especially when Arel itself
already has its very own #or method to accomplish this within the
relation chaining.
It seems odd to me that chaining a second where *adds* to the
dataset of the first where.
Exactly.
-Steve
@jangosteve
--
You received this message because you are subscribed to the Google Groups "Ruby on
Rails: Core" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
