On Mar 24, 11:48 am, Evgeniy Dolzhenko <[email protected]> wrote: > On 3/24/2011 2:33 PM, Frederick Cheung wrote: > > > > > On Mar 23, 6:18 pm, Jos Valim<[email protected]> wrote: > >> Note: it seems google ignored my original post. Sorry if it ends up > >> twice. > > >> Yes, it is a bug. > > >> Here is a very simple fix that considers your scenario and the one in > >> the original patch:https://gist.github.com/883459 > > > Looks good! > > Since you guys are already working on it can I also get some feedback on > this > commenthttps://rails.lighthouseapp.com/projects/8994/tickets/5674-regression... > ? > We should be ok there - The ticket/commit i linked to earlier adds tests ensuring that before_destroy fires before any destroying happens (although unfortunately in a way that introduces problems when foreign keys are in use). José's proposed fix won't break that
Fred > (To repeat: patch solves the problem with the DB keys but any > before_destroy callback on the model with HABTM assoc will see that > assoc already emptied when fired) -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
