Worth fixing. Please give 1.9.3 a shot too. Even if we don't do a gem release, folks can target the `2-3-stable` branch.
On Fri, Dec 23, 2011 at 12:20 PM, Andrew Selder <[email protected]>wrote: > Just a quick heads up for everyone. > > Rails 2.3.14 is not completely Ruby 1.9.2 compatible. > > Specifically the vendored version of TMail in ActionMailer calls > String#is_binary_data?. This method was removed from Ruby in 1.9.2. > > I realize that this probably won't be fixed as Rails 2.x is EOL, but I'm > just putting it out there in case other people run into the problem. > Personally I'd advocate a fix, Rails 2.3 promised Ruby 1.9 compatibility > and this breaks that promise. > > A simple workaround is to copy the definition of the method forward and > add it to the String class in an initializer. > > Here is it for reference (copied from apidock.com) > > def is_binary_data? > (self.count("^ -~", "^\r\n\").fdiv(self.size) > 0.3 || > self.index("\x00")) unless empty? > end > > > Andrew > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
