On Friday, March 2, 2012 7:25:34 PM UTC-5, Aaron Patterson wrote: > > On Fri, Mar 02, 2012 at 01:26:18PM -0800, Mark Peterson wrote: > > So ActiveResource::Base.include_root_in_json is no longer supported, and > > then I encounter the following within Json Formats: > > > > module ActiveResource > > module Formats > > module JsonFormat > > def decode(json) > > Formats.remove_root(ActiveSupport::JSON.decode(json)) > > end > > end > > end > > end > > > > If ActiveResource::Base.include_root_in_json felt hacky enough to > remove, > > didn't that change above feel even more hacky? > > Yes? > > Sorry, I don't understand the question. Is there a bug? > > -- > Aaron Patterson > http://tenderlovemaking.com/ >
Yes, it violates the principal that the function should do only what it claims to do. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/PMMdRYBf0KwJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
