What about using a routing constraint for allowing the entire file extension?

E.g.  match "/download/:filename", :to => "downloads#download", :constraints => 
{ :filename => /.+/ }


On Aug 4, 2012, at 11:33 AM, Alexey <[email protected]> wrote:

> Hello,
> 
> would it be ok to allow formats with a dot in routing requests, like 
> "`http://example.com/users.xml.zip`";?
> 
> If i am not mistaken, in this situation rails is only trying to match "zip" 
> for format.  I doubt many people are using such routes now because the 
> controller part is not correctly recognized and the route is not matched 
> automatically at all, so this change should not break many applications.
> 
> I can think about a PR if i have time, i would appreciate an indication which 
> source file to look at.
> 
> I understand that formats with a dot may have other issues, but i do not 
> think they are serious:
> 
> ```ruby
> respond_to do |format|
>   format.public_send(:'xml.zip') { render :'xml.zip' => @users}
> end
> ```
> 
> What do you think?
> 
> - Alexey Muranov.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To view this discussion on the web visit 
> https://groups.google.com/d/msg/rubyonrails-core/-/e2wEpsceyPgJ.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/rubyonrails-core?hl=en.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.

Reply via email to