Yeah, I think it's fine to merge it in as long as we have some code to look at :)
On Fri, Sep 7, 2012 at 2:31 PM, Godfrey Chan <[email protected]> wrote: > For something like this you might want to just do it and send a PR, it > sounds pretty reasonable so I don't think you'll have much trouble getting > it merged :) > > On 2012-09-06, at 6:35 AM, Ex wrote: > > date_select has option :order which provide array containing :day, :month > and :year. > > But datetime_select doesn't allow to provide, for example that: > > *:order => [:hour, :minute, :day, :month, :year**]*. > > I think that adding few elements, such as :hour, :minute for :order > option in datetime_select would be very useful. > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/rubyonrails-core/-/OhYr1Mh6MCAJ. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > -- At. Carlos Antonio -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
