I found a commit that was merged into master that actually breaks 
FormOptionHelper#time_zone_options_for_select.  I seem to keep running into 
these. :-)

The commit in question is 
here: 
https://github.com/rails/rails/commit/b4051edf841c8a6780df9af7afa9892bfd811c79

I have commented on the commit explaining the problem.  I am not clear on 
what the standard procedure is for simply removing a commit from Rails 
though which is what I think should be done here essentially.  I can create 
a new PR that puts things back how they were before the commit but I'm not 
sure if that's the right way or if you guys would rather just unwind the 
changes and do some git magic to remove the commit completely from history?

If a PR to remove it is appropriate I can work one up pretty fast.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to