Hi Ben, On Sun, Jul 21, 2013 at 10:48 AM, Ben Woosley <[email protected]> wrote: > I spent some time today reviewing, rebasing, and fixing pull requests. > https://github.com/rails/rails/pulls/Empact > > I'm starting with the oldest open PRs and working forward. Focusing on > ActiveRecord PRs, as I <3 SQL / AR. > > If I don't like what I see, I'll comment > If the change looks good I'll +1
Thats nice :) It helps a lot to revive issues. > If it looks like it may have merit but needs improvement or updating, I'll > try to improve it and open a new pull request. > I think the policy is to wait for the original implementor to improve and update, after providing feedback. Unless they dont respond a new PR won't be considered. > Is this appreciated? Is there anything you would change about? Let me know. > -Ben > > > On Fri, Jul 19, 2013 at 7:15 AM, Steve Klabnik <[email protected]> > wrote: >> >> One last point I'd like to make is that 'just giving more people >> commit' isn't going to work out. Merging bad pull requests just to get >> the numbers down isn't going to help. It would just add more work to >> clean up any messes. >> >> The only way to get more committers is for more people to do more >> work, and then they'll be given commit when they deserve it. Senny and >> myself are two examples from the past year. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/groups/opt_out.
