Hey James, This change was not intentional. Could you open a ticket and mention me and Santiago?
Thanks On Wednesday, April 9, 2014 11:09:39 AM UTC-3, James Coleman wrote: > > In Rails 3, render_to_string ensured that the response body was set to nil > after rendering so that using it to render something for purposes other > than the body and then rendering or redirecting in a controller didn't > raise a DoubleRenderError. In this commit > https://github.com/rails/rails/commit/c27fde26166f71ec68a7fb501435b656f436a687spastorino > removed that behavior. > > Is there any particular reason why this case isn't supported anymore? This > exactly problem was actually flagged as a bug back in the 3.x days here > https://rails.lighthouseapp.com/projects/8994/tickets/5875-render_to_string-json-or-xml-or-update-before-render-results-in-doublerendererrorwhich > is where the "set body to nil" behavior came from originally. > > Is this an intentional change? Or is this a bug? I realize there are other > issues to deal with now that live/streaming support also intersects with > this code. Also, there are other bugs like > https://github.com/rails/rails/issues/14173 which are also a result of > how render_to_string works (in that case, it's that the content_type of the > response shouldn't be altered by render_to_string.) > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
