`unit` is confusing too. Since once it reach 1000mb it will switch to GB.

what about `initial_unit` ?

On 21 September 2014 16:36, Kerri Miller <kerri...@gmail.com> wrote:

> How about "unit" instead of "minimal"?
>
> -k-
>
> On Sat, Sep 20, 2014 at 9:46 PM, Damian Nowak <enwuk...@gmail.com> wrote:
>
>> I'd want to show "0 MB" instead of "0 Bytes" when presenting the space
>> and memory used by virtual machines in VirtKick
>> <https://demo.virtkick.io/>. It doesn't make big sense to be that byte
>> or kilobyte-specific in that. Please provide feedback and  let me know if
>> you want me to implement it in NumberToHumanSizeConverter.
>>
>> number_to_human_size(123, minimal: :mb) # => 0 MB
>> number_to_human_size(1234, minimal: :mb) # => 0 MB
>> number_to_human_size(12345, minimal: :mb) # => 0.01 MB
>> number_to_human_size(123456, minimal: :mb) # => 0.12 MB
>> number_to_human_size(1234567, minimal: :mb) # => 1.18 MB
>> number_to_human_size(1234567890, minimal: :mb) # => 1.15 GB
>> number_to_human_size(1234567890123, minimal: :mb) # => 1.12 TB
>>
>> (Assumed the default precision of 2)
>>
>>
>> Damian
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to rubyonrails-core+unsubscr...@googlegroups.com.
>> To post to this group, send email to rubyonrails-core@googlegroups.com.
>> Visit this group at http://groups.google.com/group/rubyonrails-core.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at http://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to