Hi Will,

On Friday, December 12, 2014 5:08:32 AM UTC-7, will.bryant wrote:
>
> ...To avoid the above argument dilemma, we could provide them using a 
> block to the joins() method...
> Document.
>     joins(:votes) { where("extra join conditions to add to the ON clause 
> go here") }.
>

I see in the left_joins() PR Matt Jones makes a similar observation
https://github.com/rails/rails/pull/12071#issuecomment-41401056 

I like it - makes sense and provides backward compatibility. 

Best,
Mark

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to