Hi Rails Core,

I would like to tackle https://github.com/rails/rails/issues/17706 , but I 
have some questions.

1. Do we want the change? ( isolated 'test' 
https://gist.github.com/mess110/89f45de57fe8657da400 )

If we do,

2. Is the suggested approach good? (the one in the issue)
3. I was looking though the tests and I found 2 places where it could fit. 
Which is better?

   1. rails/activerecord/test/cases/adapters/postgresql/json_test.rb (json 
   related tests)
   2. 
rails/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb 
   (distinct related tests)


4. Going though the docs, I found:

   - http://apidock.com/rails/ActiveRecord/QueryMethods/distinct
   - 
   http://apidock.com/rails/ActiveRecord/Associations/CollectionProxy/distinct
   - 
   
http://apidock.com/rails/ActiveRecord/Associations/CollectionAssociation/distinct
   
What do you think?

Thanks,
Cristian

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to