Looks like some ActionCable actions are missing ActiveSupport 
notifications. Now that we have e.g. "perform_action" and "broadcast" 
instrumented, I suppose it'd be good to do the same for other important 
calls, namely:  "open", "close", "subscribed" and "unsubscribed". I have 
this implemented in my 
fork: 
https://github.com/xlts/rails/commit/2d9bb3197e2d3c7a522611c3ec5b778442c30362. 
Would it be reasonable to submit a PR?

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to