Hello Josef, On 2019/09/26 09:16, Josef Šimánek wrote: > Hello! > > I'm facing problem where I need to check if active record relation is > already ordered and if not I would like to order by some default column (id > in my case).
Why do you need to check? Just say what order you need, and the database will figure out whether it needs to do actual work or can skip ordering. Regards, Martin. > Right now I'm using "scope.order_values.any?" to find out current ordering > state and decide if we need to specify ordering or not. > > Anyway I'm not sure how to find out if order_values is actual public API. > It is generated method (source - > https://github.com/rails/rails/blob/cb6db15d221d261bf5060c8752ba3b8b28e3b651/activerecord/lib/active_record/relation/query_methods.rb#L77) > and it is not visible at https://api.rubyonrails.org/. But it doesn't seems > for me since it also returns array of arel nodes. > > I had an idea to contribute "order?" or "ordered?" to public API to be able > to find out if relation is already ordered. > > I have two questions: > > 1. Is order_values public API and safe to use in our Rails application? If > so, is there any way how to make it documented? > 2. If not, would be order? or ordered? method welcomed as new query method? > Implementation is really simple. > > Josef > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/31e0a380-df49-085f-03f6-2aeda6b17839%40it.aoyama.ac.jp.
