It's not completely correct, because if you want to change the css to 0,
it's evaluated as ''. Then, maybe a better fix will be:

-----------------------------------------------
if (value == 1 || value === '') {
-----------------------------------------------

Hope helps someone.


2006/12/23, Alessandro Curci <[EMAIL PROTECTED]>:


Javier Martinez ha scritto:
> Somone have tested the last scriptaculous version that ships with last
> prototype?
> I you make an Effect.Pulsate, the element stays hidden after the
> effect finish if the element don't have opacity stablished. This is
> for the changes on the setStyle method on prototype.
> The original code is:
>
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>   setStyle: function(element, style) {
>     element = $(element);
>     for (var name in style) {
>       var value = style[name];
>       if(name == 'opacity') {
>         if (value == 1) {
[cuts]
>
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Maybe this change on line 6, solve the problem:
>
> original --> if (value == 1) {
> new (?) --> if (value == 1 || value == '') {
>
> Hope somebody says something about this.
>
> Thanks.
Hi Javier,
this seems to fix the problem in script.aculo.us functional tests too,
running with FF 2.0 or IE7.

Alessandro

>


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on 
Rails: Spinoffs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to