Hi.

With regard to changeset 8149
(http://dev.rubyonrails.org/changeset/8149), there are 2 more
undefined comparisons which could/should use Object.isUndefined. Both
are negative tests, so that may be why...


  toQueryParams: function(separator) {
...
        if (value != undefined) value = decodeURIComponent(value);
...
  },

        if (value != undefined) value = decodeURIComponent(value);

could be

        if (!Object.isUndefined(value)) value = decodeURIComponent(value);



Also, Form.Element.Methods.serialize has ...

Form.Element.Methods = {
  serialize: function(element) {
...
      if (value != undefined) {
...


could be

      if (!Object.isUndefined(value)) {



-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Spinoffs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-spinoffs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to