Pale Horse wrote: > Robert Walker wrote: >> Pale Horse wrote: >>> My controller code can be seen here: >>> >>> http://pastie.org/1026480 >> >> Oh, where to begin. Unless I'm completely daft, I see only one single >> line in your new method that belongs in a "new" action.
I don't have a lot to say about the original problem that Robert didn't already mention, but I do think I should mention a couple of things about development practice that will save you a lot of grief going forward. > > I can't argue with that but this is not my site. The moment you start working on it, it is in a sense your site. Take ownership of the code and do the right things. > Frankly, I don't have > the *time* to make those kinds of amendments across the site, so in the > light of consistency, I will not make one here. That is generally poor reasoning. It is usually a good idea to "fix broken windows" -- that is, fix obviously bad code as you come across it; it will save time and incrementally improve the quality of the codebase. You don't have to make a grand refactoring sweep through the whole project if you don't have time; just fix bad code where it annoys you. See http://c2.com/cgi/wiki?FixBrokenWindows . Delaying fixes that would help you, just in order to keep some larger "consistency", is generally not a great idea. > Perhaps when I obtain > more time, I will return to this project and tighten this code. I am, > equally, not happy with this method. Despite this, it *certainly* works. If it worked, presumably you wouldn't be having problems with it. If you can't maintain it as is, then fix it. Best, -- Marnen Laibow-Koser http://www.marnen.org [email protected] -- Posted via http://www.ruby-forum.com/. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
