On 07/10/18 20:37, John Hardin wrote:
> On Tue, 10 Jul 2018, John Hardin wrote:
>
>> On Tue, 10 Jul 2018, Steven Ihde wrote:
>>
>>> Hi all,
>>>
>>> Starting Friday I noticed the mass-check is producing thousands of lines of
>>> output like this:
>>>
>>> invalid check_freemail_replyto option: Disposition-Notification-To at
>>> /dev/shm/masscheckwork/nightly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/FreeMail.pm
>>> line 543.
>>>
>>> Prior to Friday I had never seen this. Any idea what's going on?
>>
>> I just fixed that rule for not checking whether the freemail plugin is
>> loaded, but your error suggests something different is going on...
>>
>> This may be a rule that depends on a *capability* recently added to the
>> Freemail plugin. It passes lint against trunk in my test environment.
>>
>> You might want to manually "svn up" and recompile your masscheck environment.
>>
>> Giovanni, it's possible that there also needs to be a version check on that
>> rule, perhaps like:
>>
>> #if version >= 3.004001
>>
>> ...so that it doesn't cause problems with older installs if this rule gets
>> published.
>
> ...wait - it passes lint but I do get the same error in a test run:
>
> Jul 10 10:43:22.343 [13247] warn: invalid check_freemail_replyto option:
> Disposition-Notification-To at lib/Mail/SpamAssassin/Plugin/FreeMail.pm line
> 543.
>
> Perhaps Giovanni checked in the rule but not the code change to the Freemail
> plugin?
>
> Disabling the rule now, until he has a chance to review.
>
>
fix committed, I have too many M on my tree, sorry.
Giovanni
