On 14/06/15 11:54, Robert Millan wrote:
Thanks Antti. Here's the new patchset.
Almost there. Still small nits:
#ifdef RUMP_PCI_IOSPACE
- pba.pba_flags |= PCI_FLAGS_IO_OKAY;
+#ifdef rumpcomp_pci_initiopl
+ error = rumpcomp_pci_initiopl();
+ if (error == 0) {
+ pba.pba_flags |= PCI_FLAGS_IO_OKAY;
+ } else {
+ aprint_error("pci: unable to raise I/O privilege level (error %d),
direct I/O will be unavailable\n", error);
+ }
+#endif
#endif
The print still doesn't match the call. How do you know at that
abstraction level that initiopl() will exactly "raise I/O privilege level"?
Also, do we still need RUMP_PCI_IOSPACE? Or can we say that everything
providing iospace access must now define rumpcomp_pci_initiopl?
