On 04/03/16 16:23, Martin Lucina wrote:
On Friday, 04.03.2016 at 16:05, Antti Kantee wrote:
On 04/03/16 15:38, Martin Lucina wrote:
Two patches here, one for rumprun (the user of these variables), another
for src-netbsd. Please review. Fixes rumprun issue #38 (build fails on
certain distros with dash as /bin/sh).
Those variables the current public "API", so I'd not remove the old
variables, just += the new ones.
Not sure if that's possible. RUMPCOMP_USER_PATH is used to set .PATH, which
according to the make documentation must be updated by setting the .PATH
target, so there's no easy way to do +=.
.PATH is essentially +=, i.e. you can specify it many times. However,
I'm not sure if it will barf from an empty value or not, but in any case
you can use an intermediate variable.
Who are the other downstream users that may be affected by this change?
What do you mean by "downstram users"?
What I meant was "does this change break an API (the variable names) which
will affect users other than rumprun"?
Yes, that's why I suggested +=.
