Ian Jackson writes ("Re: [PATCH RFC 0/3] rumpuser-xen: Provide 
rumpuserxen-app-* helpers"):
> Antti Kantee writes ("Re: [PATCH RFC 0/3] rumpuser-xen: Provide 
> rumpuserxen-app-* helpers"):
> > So I tried the tools out on x86_64.  There are a few hiccups over 32bit:
> > https://github.com/rumpkernel/rumpuser-xen/compare/tools-x64
> > 
> > Looks sane?
> 
> Yes, thanks.

Actually, I have just looked at the FM and this

       case "$a" in
  -    [^-]*|-L*|-l*|--whole-archive|--no-whole-archive)
  +    [^-]*|-L*|-l*|-z|--whole-archive|--no-whole-archive)
               outargs+=("$a")

seems wrong.  The FM says that -z takes a keyword argument.

I think you need something like:

       -z)
               outargs+=("$a" "$1"); shift || noshift
               ;;

(untested).

In practice this won't make any difference unless ld grows a -z
keyword starting with a hyphen, but I think it is better to do the
parsing/unparsing correctly.

Ian.

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck®
Code Sight™ - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
rumpkernel-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rumpkernel-users

Reply via email to