Great. Some comments on the patch:
I will reply on the patch itself in a second.
I am setting up a github account and repo, but for now the patch is
attached
I manged to reset my password *and* forget it at home today :-(. Will
make sure to have it tomorrow, but for now more attached patches.
Ok. We'll need at least the mozilla foundation committer paperwork from
you as well, unless you've been vetted for a mozilla project commit
level yet. I'll file a bug if not.
I should have all the paperwork in place, but don't have any commit
access yet (as rust is my first project). How do I check if the
paperwork was already processed?
Since we have so few tests runnning on rustc at the moment, we currently
abuse the XFAIL concept and enumerate a list of the tests that *are*
passing in TEST_XFAILS_SELF, wrapping the whole thing in a $(filter-out
...) call. So by default rustc will not run a test until you list it in
TEST_XFAILS_SELF. At some point we'll invert this back and make it a
proper XFAIL list.
I noticed that rustc was never being used and that was because I had the
bindings disabled. I assume this is from the days llvm was used via the
ocaml bindings. The attached patch should fix that.
*) Is there a syntax only mode? I had to add the main function to
prevent a crash.
No, but I wouldn't object to one. Part of the point of moving to a more
functional form in rustc is to make the passes more independently
testable. Feel free to add command-line processing to
comp/driver/rustc.rs that supports partial pass-execution like that.
Nice. For now I changed the test to use valid crates so that rustboot is
happy with it.
-Graydon
Cheers,
Rafael
diff --git a/src/Makefile b/src/Makefile
index c77b899..c2d4451 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -194,8 +194,6 @@ ifneq ($(CFG_LLVM_CONFIG),)
done)
ifneq ($(CFG_OCAML_LLVM),)
$(info cfg: found LLVM ocaml bindings in $(CFG_OCAML_LLVM))
- else
- CFG_LLVM_CONFIG := $(info cfg: LLVM ocaml bindings not found)
endif
endif
_______________________________________________
Rust-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/rust-dev
