On 13-05-25 11:36 AM, Gareth Smith wrote: > On 10/05/13 01:45, Graydon Hoare wrote: >> On 13-05-07 08:09 AM, Sanghyeon Seo wrote: >>> Here are some feature requests to bors queue status page at >>> http://buildbot.rust-lang.org/bors/bors.html >>> >>> 3. OUTDATED state, for pull requests that need to be rebased. GitHub >>> API provides "mergeable" attribute for this. >> I've fixed #1 and #3 today (as well as adding last-comments and a >> DISCUSSING state). I'll look into #2 soon. Thanks for the feedback. > > I am guessing that STALE on http://buildbot.rust-lang.org/bors/bors.html > means "needs rebase" - right? > > How does a pull request leave the STALE state? Does it have to be > reviewed again or will the status update automatically at some point > after rebasing? I have rebased https://github.com/mozilla/rust/pull/6433 > but it still shows as STALE.
Interesting. That pull req is closed but ... it should not be happening. It should only say STALE if it's in the state where github says it can't be merged (i.e. "We can’t automatically merge this pull request. to resolve conflicts before continuing."). That's the API we're asking, anyways! Once un-STALE, it should go back to UNREVIEWED or DISCUSSING. I now see what while _most_ of the current STALE requests are like that, one in particular (https://github.com/mozilla/rust/pull/6703) is not. So this is either a github API problem or a bug in bors. I'll look into it shortly. Thanks for reporting it. -Graydon _______________________________________________ Rust-dev mailing list [email protected] https://mail.mozilla.org/listinfo/rust-dev
