On Sun, Jul 28, 2013 at 1:30 PM, Patrick Walton <[email protected]> wrote: > On 7/28/13 9:52 AM, Corey Richardson wrote: >> >> On Sun, Jul 28, 2013 at 12:44 PM, Patrick Walton <[email protected]> >> wrote: >>> >>> Wow! We should do this by default. >>> >> >> Not sure this is a good idea, not as long as we still have >> LLVM-related ICEs and assertions. >> > > Well, keep in mind that debug logging is now turned off unless you build > with CFG_ENABLE_DEBUG, so assertions aren't really debuggable anymore > without building the compiler in debug mode. So folks debugging assertions > will have to build without CFG_ENABLE_DEBUG, and I think it's reasonable to > have LLVM assertions on for those builds. > > Patrick
I think the issue is that we may have silent, uncaught bugs if we turn off LLVM assertions by default. An assertion might not be easy to debug by default, but we'll still get a bug report from a user who runs into one. _______________________________________________ Rust-dev mailing list [email protected] https://mail.mozilla.org/listinfo/rust-dev
