So, I've been trying to use default methods to streamline various
parts of the Rust compiler and libraries.  Most recently, I tried
attacking the impls of Visitor in libsyntax.  Since the Visitor trait
already had default methods, the patch consists entirely of removed
lines:

https://github.com/lkuper/rust/commit/7950e5fbc26494c437237cb1a5b4583f7b6881e8

It builds without issue, but unfortunately, the results of `make
check` are interesting.  I get three run-pass test failures:

failures:
    [run-pass] run-pass/issue-2216.rs
    [run-pass] run-pass/issue-9047.rs
    [run-pass] run-pass/labeled-break.rs

These three tests all have something to do with labeled
break/continue, and they all segfault.  (Gist of all build messages
here: https://gist.github.com/lkuper/6532993) Anyone have an idea why
this change would result in this failure?  The Visitor trait is used
all over the compiler, but I didn't have to touch it at all, so it
seems like the problem should be local to libsyntax.

Lindsey
_______________________________________________
Rust-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/rust-dev

Reply via email to