You must fork the rust repository, and then push your changes to your fork, and then open a pull request.
See https://github.com/mozilla/rust/wiki/Note-development-policy and https://github.com/mozilla/rust/wiki/Note-git-workflow On Tue, Nov 26, 2013 at 1:15 PM, Philippe Delrieu <[email protected]> wrote: > I try to commit my change on json.rs but I didn't manage to make it work. > I'am not very use to git. I've done : >>git clone https://github.com/mozilla/rust.git >>git rebase master >>git push --> error 403. I use my github account > > Sorry for to ask for get but can anybody tell me what to do to send my > change. > > Philippe Delrieu > > Le 22/11/2013 19:22, Philippe Delrieu a écrit : > >> I've done the modification in json.rs (add comment with sample code in md >> format and test code). >> I've do the commit and git pull. >> >> The test compile but I didn't manage to run it. >> I use the command: make -j 20 check TESTNAME=src/libextra/json.rs >> There are errors before and when I force the assert to false I have no >> error for json. >> >> Tell me if it's ok. >> >> Philippe >> >> Le 22/11/2013 10:07, Corey Richardson a écrit : >>> >>> On Fri, Nov 22, 2013 at 3:33 AM, Philippe Delrieu >>> <[email protected]> wrote: >>>> >>>> I finished my test with the rust json API. I made a non trivial example >>>> code >>>> that summaries what I understand. I put it at the end of the mail. Could >>>> someone (the developer of the API for example) add it to the comment of >>>> the >>>> json API. I don't think I have the right. It can be good to add it as a >>>> test >>>> case to validate that it stay up to date. >>>> Put any remarks about the code if I've made some mistake or if there is >>>> better code. >>>> >>> Send a pull request adding it. >>> >>> >> >> _______________________________________________ >> Rust-dev mailing list >> [email protected] >> https://mail.mozilla.org/listinfo/rust-dev > > > _______________________________________________ > Rust-dev mailing list > [email protected] > https://mail.mozilla.org/listinfo/rust-dev -- Andrew Chin | [email protected] _______________________________________________ Rust-dev mailing list [email protected] https://mail.mozilla.org/listinfo/rust-dev
