On Sat, Apr 26, 2008 at 02:58:42PM +0900, Neil Booth <[EMAIL PROTECTED]> wrote:
> > > + // Reset to initial conversion state from undefined
> > > + mbrtowc (0, 0, 0, mbstate);
> >
> > This would introduce a bug (it would eat characters at the end of the
> > buffer). Are you sure netbsd requires this? If yes, then netbsd is buggy.
>
> I'm not sure about your point about a buffer,
The buffer is the input pointer passed in to mbrtowc (from context, yes :)
> > however, should not, in theory, in this case, the buffer returned by
> > wcrtomb added to the string (wcrtomb returns a reste shift state sequence
> > in this case)?
>
> Indeed, you're right, if I understand what you're saying the attached
> revised patches are probably better. I can confirm that that
> rxvt-unicode with these revised patches applied also behaves
> properly on NetBSD after cat-ting a file badly encoded for the current
> locale.
Yes, the function isn't used for normal terminal I/O.
> > Both fixes are applied and will be part of the next release, which will
> > include a fix for the select backend used on netbsd as well... :)
>
> That's great, thanks! Not sure what the select backend is though....
What matters is that it is broken on 64 bit systems that use select(2),
such as netbsd, and will be fixed soon :)
Thanks for your revised patch, I will look into it (there should imho be a
"?", and I wonder wether the space is sufficient then).
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / [EMAIL PROTECTED]
-=====/_/_//_/\_,_/ /_/\_\
_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
