2009/8/2 Thomas Adam <[email protected]>:
> Hi,
>
> With recent Xorg upgrades, grabbing synchronously when a popup window
> is mapped is fatal, as this sends the event loop to continually wait
> for the server to come available again which it can't do as nothing is
> ever releasing the grab. The fix then is for the callers to *not*
> force synchronous mode when calling rxvt_term::grab().
>
> See patch attached.
>
> (Note that originally I was almost tempted to just mangle the
> selection of GrabModeSync and GrabModeAsync to always be
> GrabModeAsync, however there's perfectly valid times when something
> might want to grab synchronously -- it's just nothing uses that yet.)
Helps if I attach the patch...
-- Thomas Adam
Index: src/perl/urxvt-popup
===================================================================
RCS file: /schmorpforge/rxvt-unicode/src/perl/urxvt-popup,v
retrieving revision 1.15
diff -u -r1.15 urxvt-popup
--- src/perl/urxvt-popup 24 Dec 2007 08:21:40 -0000 1.15
+++ src/perl/urxvt-popup 2 Aug 2009 08:22:52 -0000
@@ -120,7 +120,7 @@
$self->refresh;
# might fail, but try anyways
- $self->grab ($self->{data}{event}{time}, 1)
+ $self->grab ($self->{data}{event}{time})
and $self->allow_events_async;
on_button_press $self, $self->{data}{event} if $self->{data}{event}{button};
@@ -132,7 +132,7 @@
my ($self, $event) = @_;
# should definitely not fail
- $self->grab ($self->{data}{event}{time}, 1)
+ $self->grab ($self->{data}{event}{time})
and $self->allow_events_async;
}
_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
