On 25.11.2010 15:27, Emanuele Giaquinta wrote:
> The patch is not correct; configure should look for fontconfig only if
> xft support is requested and should not enable xft support if fontconfig
> is not available.
Fair point. This one should be better.
> > (note the use of PKG_CHECK_MODULES, I was wondering why you are
> > handling all the pkg-config details manually in configure.ac, and not
> > using PKG_* macros?).
>
> Is there an advantage in using PKG_CHECK_MODULES (the disadvantage is a
> dependency on pkg-config m4 file) ?
m4 dependency hits only author who provides tarballs and those who wish,
for some reason, to reconfigure project. Not a very big deal in my
opinion, especially considering fact that m4 is included when
pkg-config is installed, which is a must have for anybody who builds
anything from source. And by using macros one gains more readable and
easier to maintain configure.ac.
Best regards,
Jan Palus
diff -ur rxvt-unicode-9.09.orig/configure.ac rxvt-unicode-9.09/configure.ac
--- rxvt-unicode-9.09.orig/configure.ac 2010-11-25 15:38:24.520226813 +0100
+++ rxvt-unicode-9.09/configure.ac 2010-11-25 15:46:27.880226847 +0100
@@ -641,10 +641,16 @@
fi
fi
+ if test $PKG_CONFIG != no && $PKG_CONFIG --exists fontconfig; then
+ X_LIBS="`$PKG_CONFIG fontconfig --libs` $X_LIBS"
+ CPPFLAGS="$CPPFLAGS `$PKG_CONFIG fontconfig --cflags`"
+ fi
+
save_LIBS="$LIBS"
LIBS="$LIBS $X_LIBS"
AC_CHECK_HEADERS(X11/Xft/Xft.h,,[support_xft=no])
AC_CHECK_LIB(Xft,XftDrawString32,:,[support_xft=no])
+ AC_CHECK_LIB(fontconfig,FcPatternGet,:,[support_xft=no])
LIBS="$save_LIBS"
if test x$support_xft = xyes; then
_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
