On Mon, Mar 14, 2011 at 09:18:25PM +0100, Marc Lehmann wrote:
> On Mon, Mar 14, 2011 at 08:30:32PM +0100, Tomas Cech <[email protected]> 
> wrote:
> > I started recently to modify the terminal behaviour for
> > shift+pageup/pagedown key presses in alternate screen mode. Since
> > alternate screen has exact size as visible part of terminal screen,
> > these key combintations doesn't have that good reason for history
> > scrolling.
> 
> Not really, both primary and secondary screen are the same size, the
> scrollback is shared, and it's behaviour can be configured via various
> resources (e.g. look at secondaryScroll).

Ok. Lets say that I'd like to add new configuration option for such
behaviour. Terminals like konsole or VTE based terminals doesn't even
allow to scroll when in using secondary screen. Such event is simply
dropped. That's the reason I started this little war.

> 
> > application running inside terminal. I see this as possibility for
> > programs like screen and tmux that they can provide history of their
> > terminal more naturally.
> 
> At least screen already has keybindings for history scrolling and
> searching, while your patch apparently implements something that screen
> doesn't use yet, while leaving history searches broken.

Yes, both screen and tmux can enter some copy mode, where the history
is accessible. On my opinion there is room for improvement. I don't
want to make drastic changes or force users to use it, but I believe
this function is step forward. Just imagine when you want to scroll
screen history in screen running in screen running in screen... If
screen would enter into secondary screen mode and also supported this
behaviour, you could work with the most inner screen in the same way
as with other terminal (so no C-a,a,a,ESC).
> 
> > shift+up/down doesn't work at all. I hope that the idea is clear.
> 
> Reasonably well to me, I hope, but it seems you create a bigger mess than
> before - at least, right now, it's consistent.

What it is consistent with? I'd like to alter behaviour of several
(mostly used) terminals and hope that users will enjoy that.

> 
> > -                }
> > +                             if (current_screen == SECONDARY && 
> > option(Opt_secondarySendScroll)) {
> 
> Also, your patch is absolutely horribly formatted - as a general hint: if
> you are interested in having a patch applied by the maintainers of some
> software, you should follow the existing coding style, as a minimum. as it
> is, the patch is completely unreadable for me.

Yes, sorry, this surely isn't the final version of the patch. I was
writing in public transport on my little ARM netbook. I sent it to
make my idea more clear and maybe to get answers for the questions I
sent.

Thanks for answer.

Best regards,

Tomas Cech

Attachment: pgpKQgrgq197n.pgp
Description: PGP signature

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode

Reply via email to