Hi Mikael, Excerpts from Mikael Magnusson's message of 2011-11-13 15:12:05 +0000: > > Hello, the patch looks fine, but there are some code style issues. > > - the ./configure --help line should have two spaces separating the > > help text from the option name when the name is too long. > > - use a space before opening ( even for function calls and macros. > > - put an empty line after } > > I forgot to add that the option also needs to be documented in > rxvt.7.pod under "configure options". > > > If you fix these issues we will apply the patch, thanks. Everything fixed, thanks for the feedback.
I attached the updated version of this patch. Best regards, Michael
0001-Implement-support-for-freedesktop-startup-notificati.patch
Description: Binary data
_______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
