Hi, rxvt-unicode folks,

On case-insensitive filesystems, the INSTALL file prevents `make install` from working. This breaks the installation process on OS X, since the default filesystem there is case-insensitive. E.g. I get this when building on OS X 10.9.5.

$ make install
make: `install' is up to date.


Explicitly tagging "install" and other phony targets fixes this. The Homebrew package manager formula patches Makefile during the build to do so[1], but it would be nice if the main distribution built out of the box. Would you consider pulling this in?

Here's a patch to do so.

Index: Makefile.in
===================================================================
RCS file: /schmorpforge/rxvt-unicode/Makefile.in,v
retrieving revision 1.39
diff -u -r1.39 Makefile.in
--- Makefile.in    22 Sep 2012 15:53:37 -0000    1.39
+++ Makefile.in    24 Feb 2016 01:24:16 -0000
@@ -30,6 +30,7 @@
 subdirs = src doc

RECURSIVE_TARGETS = all allbin alldoc tags clean distclean realclean install
+.PHONY: $(RECURSIVE_TARGETS) check cleandir distdir

 #-------------------------------------------------------------------------
=== end patch ===

References:
[1] https://github.com/Homebrew/homebrew-x11/blob/a5379edde140ecd56267267af86fb98b6a8b75a0/rxvt-unicode.rb#L118

Cheers,
Andrew

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/mailman/listinfo/rxvt-unicode

Reply via email to