On Tue, Jun 28, 2016 at 03:24:45PM +0800, Fengguang Wu <[email protected]> 
wrote:
> > - Is the speed gain given by hashing significant enough to justify the
> >   additional space of 'rgb24_index'?
> 
> There will no user noticeable performance change, I guess. Feel free

Do you happen to have some benchmark numbers assuming excessive use of
this sequence? If it would considerably reduce cpu usage of urxvt it would
be useful, even if there is no obvious user-visible difference.

I guess a difficult workload would be something like libcaca using these
sequences, but likewise, I am not sure it is worth optimizing for that.

In any case, for me the patch is good to go, but Emmanuele is not convinced
either way about the hashing. If it provides no real difference in practial
situations, he will remove it when applying. IF it does make an actual
difference, we would like to keep it.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      [email protected]
      -=====/_/_//_/\_,_/ /_/\_\

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/mailman/listinfo/rxvt-unicode

Reply via email to