On 09.11.2016 03:12, Marc Lehmann wrote:

>> Instead of silently enabling it in rxvt.h for ENABLE_PERL, it will
>> generate an error during the configure run.
> 
> What does "it" refer to, and what is the point of this patch?

ENABLE_FRILLS/ENABLE_COMBINING, which currently gets defined in src/rxvt.h in 
case of ENABLE_PERL.

This might cause confusion, and should therefore be checked during configure 
time instead.


>> -/* Define if you don't want any resources read */
>> +/* Define if you do not want any resources read */
> 
> What is this change for?

Unrelated, should not have been included in this patch probably, and feel free 
to leave it out.  I noticed that the Vim highlighting got confused by the "'", 
and then also thought that "do not" is better than "don't" in "formal" texts.
There are two other instances of this though anyway (with backspace-key and 
delete-key).  So those should get changed, too - if this makes sense to you.


Cheers,
Daniel.

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/mailman/listinfo/rxvt-unicode

Reply via email to