On Mon, Dec 3, 2018 at 2:12 PM Marc Lehmann <[email protected]> wrote: > > On Fri, Nov 30, 2018 at 06:45:10PM -0500, hot12shots <[email protected]> > wrote: > > Thanks for your consideration. > > Thanks for your patch - it looks quite good (mostly follows the existing > coding style, adds documentation etc.). I''ll try to apply it and make it > zero-cost when systemd is not compiled in. > > > + char supplied_fd = 0; > > This should be "int", right? >
I think char is probably safe (systemd will always send descriptor 3) but it does make the code confusing for no real benefit. I'll change this when I resend the patch per your other message. > -- > The choice of a Deliantra, the free code+content MORPG > -----==- _GNU_ http://www.deliantra.net > ----==-- _ generation > ---==---(_)__ __ ____ __ Marc Lehmann > --==---/ / _ \/ // /\ \/ / [email protected] > -=====/_/_//_/\_,_/ /_/\_\ _______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/mailman/listinfo/rxvt-unicode
