On Thu, Mar 08, 2012 at 06:28:34AM +0900, FUJITA Tomonori wrote: > On Wed, 7 Mar 2012 20:55:39 +0900 > Isaku Yamahata <[email protected]> wrote: > > > This patch series splits up handshake into more phase. > > Then it can be easily hooked up. > > With this refactoring, cbench work around is contained in cbench app itself. > > > > Isaku Yamahata (3): > > ofproto: add known list of desc stats and helper functions > > controller/handler: split out handshack into more phase > > app/cbench: add cbench specific work around > > > > ryu/app/cbench.py | 26 ++++++++ > > ryu/app/simple_isolation.py | 4 +- > > ryu/controller/controller.py | 1 + > > ryu/controller/handler.py | 73 > > +++++++++++++++++------ > > ryu/{controller/dp_type.py => ofproto/desc.py} | 33 ++++++++--- > > 5 files changed, 106 insertions(+), 31 deletions(-) > > copy ryu/{controller/dp_type.py => ofproto/desc.py} (50%) > > I'm not sure about this. I think that splitting up handshake is ok but > I don't think that adding the knowledge of various switches into ryu > core or trying to see what switch is this dp in ryu core is a good > idea. Such method is fragile. I think that such info should de available > somewhere else (e.g. database). > > As I wrote before, even moving into the known state isn't good in some > situations. I think that we should provide applications a way to > start up switches in their way.
The motivation is to split up handshake and allow applications to hook initialization easily. Then, remove the app/switch specific knowledge out of core logic. I think we agreed with the direction. But the implementation is not in good shape. -- yamahata ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
