On Mon, 7 May 2012 13:44:45 +0900
Isaku Yamahata <[email protected]> wrote:
> On Mon, May 07, 2012 at 07:18:34AM +0900, FUJITA Tomonori wrote:
>> diff --git a/ryu/ofproto/ofproto_v1_0_parser.py
>> b/ryu/ofproto/ofproto_v1_0_parser.py
>> index 8ea3321..3cb6830 100644
>> --- a/ryu/ofproto/ofproto_v1_0_parser.py
>> +++ b/ryu/ofproto/ofproto_v1_0_parser.py
>> @@ -420,6 +420,27 @@ class NXActionSetTunnel64(NXActionHeader):
>> msg_pack_into(ofproto_v1_0.NX_ACTION_SET_TUNNEL64_PACK_STR, buf,
>> offset, self.type, self.len, self.vendor,
>> self.subtype,
>> self.tun_id)
>> +
>> +
>> +class NXActionMultipath(NXActionHeader):
>> + def __init__(self, fields_, basis_, algorithm_, max_link_, arg_,
>> + ofs_nbits_, dst_):
>> + super(NXActionMultipath, self).__init__(
>> + ofproto_v1_0.NXAST_MULTIPATH,
>> + ofproto_v1_0.NX_ACTION_MULTIPATH_SIZE)
>> + self.fields = fields_
>> + self.basis = basis_
>> + self.algorithm = algorithm_
>> + self.max_link = max_link_
>> + self.arg = arg_
>> + self.ofs_nbits = ofs_nbits_
>> + self.dst = dst_
>> +
>> + def serialize(self, buf, offset):
>> + msg_pack_into(ofproto_v1_0.NX_ACTION_MULTIPATH_PACK_STR, buf,
>> + offset, self.type, self.len, self.vendor,
>> self.subtype,
>> + self.fields, self.basis, self.algorithm,
>> self.max_link,
>> + self.arg, self.ofs_nbits, self.dst)
>>
>>
>> class OFPDescStats(collections.namedtuple('OFPDescStats',
>
> The logic itself looks good. But what's the point of appending '_'?
No point, I just thought that appending '_' to only reserved word
valuables looks inconsistent. But I perfer to remove appended '_'
(avoiding reserved words).
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
