On Tue, Jun 19, 2012 at 10:24:48PM +0900, FUJITA Tomonori wrote: > OFPMatch is slightly different from NXMatch so I implemented it > slightly differently.
I am interested to know which differences you are thinking about. On the Open vSwtich side I believe that the only implementation differences are: * Different header constants * Different width of in_port In general the policy for other differences, in particular different wildcard rules, is to adopt the most general rule for both OXM and NXM. Personally I might have chosen to implement stricter enforcement of OXM and NXM parsing. However, it does simplify the code and I believe that is why Ben Pfaff prefers the approach taken by Open vSwtich. And I'm not entirely convinced that stricter parsing would be a win in practice. > I've not implemented all matches. I'll do if the code looks ok. The comment above aside, the code looks good. Reviewed-by: Simon Horman <[email protected]> ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
