On Wed, 20 Jun 2012 09:21:32 +0900 Simon Horman <[email protected]> wrote:
> On Wed, Jun 20, 2012 at 07:54:10AM +0900, FUJITA Tomonori wrote: >> I'm not sure where is the best place for this. Any suggestion? > > I have no strong feelings on this, but this location does seem > better than ryu/ofproto/nx_match.py, where a limited number > of these constants currently exist. > > Personally I would rather just add constants to ip.py as they are needed, > but I don't feel strongly about that either. > > I have verified that the constants you have are correct. > I used the Linux kernel as a reference. I just copied them from Linux kernel. I don't have no preference. How about adding only IPPROTO_ constants that OVS uses now? Ryu is likely to use them. - >From 6e12052f5721e27d210f11ee479515da890421e4 Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori <[email protected]> Date: Wed, 20 Jun 2012 11:21:09 +0900 Subject: [PATCH] add IPPROTO_ constants NXM and OXM code need IPPROTO_ constants. They can be shared safely (will not be changed). So better to share them in a common file. This adds only IPPROTO_ constants that OVS uses now, which we are likely to use. Signed-off-by: FUJITA Tomonori <[email protected]> --- ryu/ofproto/in.py | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 ryu/ofproto/in.py diff --git a/ryu/ofproto/in.py b/ryu/ofproto/in.py new file mode 100644 index 0000000..67126f7 --- /dev/null +++ b/ryu/ofproto/in.py @@ -0,0 +1,27 @@ +# Copyright (C) 2012 Nippon Telegraph and Telephone Corporation. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +# implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +IPPROTO_IP = 0 +IPPROTO_HOPOPTS = 0 +IPPROTO_ICMP = 1 +IPPROTO_TCP = 6 +IPPROTO_UDP = 17 +IPPROTO_ROUTING = 43 +IPPROTO_FRAGMENT = 44 +IPPROTO_AH = 51 +IPPROTO_ICMPV6 = 58 +IPPROTO_NONE = 59 +IPPROTO_DSTOPTS = 60 -- 1.7.4.4 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
