On Tue, 21 Aug 2012 13:34:09 +0900 Isaku Yamahata <[email protected]> wrote:
> On Tue, Aug 21, 2012 at 01:08:06PM +0900, FUJITA Tomonori wrote: >> On Tue, 21 Aug 2012 13:00:36 +0900 >> Isaku Yamahata <[email protected]> wrote: >> >> > Basically looks good. Some nitpicks below. >> > >> > pack_str is class constant and private, so it should be capital, _PACK_STR. >> > some comments inlined. >> >> It's python style rule? > >>From ryu/HACKING.rst >> * Google python style guide is very helpful >> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html >> >> Guidelines derived from Guido's Recommendations > > It is better/easier to adopt widely accepted style guide than > to define Ryu-own style guide. No objection. I'm just too lazy to read through any guide. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
