On Tue, 28 Aug 2012 09:31:01 +0900
OHMURA Kei <[email protected]> wrote:

> 2012/8/27 FUJITA Tomonori <[email protected]>:
>> On Fri, 24 Aug 2012 17:05:15 +0900
>> OHMURA Kei <[email protected]> wrote:
>>
>>> This patch implements REST API for accessing state. This module helps
>>> your debugging and retrieving various statistics. It also supports
>>> flow entry pusher to allow users to manually insert flows into switch.
>>>
>>> - get all switch DPIDs connected to the controller
>>>  $ curl http://<controller_ip>:8080/stats/switches
>>>
>>> - get the desc stats
>>>  $ curl http://<controller_ip>:8080/stats/desc/<dpid>
>>>
>>> - get flows stats
>>>  $ curl http://<controller_ip>:8080/stats/flow/<dpid>
>>>
>>> - get ports stats
>>>  $ curl http://<controller_ip>:8080/stats/port/<dpid>
>>>
>>> - add a flow entry
>>>  $ curl -d '{"dpid": "1", "cookie":"0", "priority":"32768", \
>>>    "actions":[{"port":2, "type":"OUTPUT"}], "match":{"in_port":1}}' \
>>>    http://<controller_ip>:8080/stats/flowentry
>>>
>>> - delete all flows of the switch
>>>  $ curl -X DELETE \
>>>    http://<controller_ip>:8080/stats/flowentry/clear/<dpid>
>>>
>>> Signed-off-by: OHMURA Kei <[email protected]>
>>> ---
>>>  ryu/app/rest_stats.py |  385 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 385 insertions(+)
>>>  create mode 100644 ryu/app/rest_stats.py
>>
>> - Please fix a pep8 warning.
>>
>> - this supports only OF1.0. We add a new file for OF1.2? Or we add
>>   OF1.2 support to this file?
> 
> We had better add a new file against every OF version. In addition, we

Then I guess that this file should be named something like
hoge_rest_1_0.py?

> need to use this feature as the single Ryu application for
> environments that consists of various OF version.

Yeah, so with your approach, users need to run multiple files for
various versions?


>>
>> - 'rest_stats' name sounds strange. This also supports adding/deleting
>>   flows (not only getting stats).
> 
> How about rest_switch or rest_ofctl ?

ofctl_rest?

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to